feat: support multicords keybinding recording#226
Closed
xinnjie wants to merge 3 commits intosindresorhus:mainfrom
Closed
feat: support multicords keybinding recording#226xinnjie wants to merge 3 commits intosindresorhus:mainfrom
xinnjie wants to merge 3 commits intosindresorhus:mainfrom
Conversation
Author
|
This could be a niche need, but I need this functionality badly. My task is recording editor shortcut like |
Owner
|
I'm unfortunately not interesting in adding support for multicords keybinding. It adds a lot of complexity and there is not much demand for it. I am willing to take the recorder options though, like allowOnlyShiftModifier and checkMenuCollision. |
Author
|
I completely understand your decision. Thanks for your reply.
I could make a PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ShortcutRecordViewto support multicords keybinding recording, for example,Ctrl-K Ctrl-S.Note that it does not support
KeyboardShortcuts.onKeyDownandKeyboardShortcuts.onKeyUpyetrelated to #225